On Fri, Jan 04, 2013 at 10:49:12AM -0700, Stephen Warren wrote:
On 12/25/2012 11:53 PM, Kuninori Morimoto wrote:
+- simple,asoc,cpu : phandle for platform
"cpu" isn't a very good name; it couuld mean anything. "platform" is an ASoC-specific term. I think this would be better written as:
simple-audio,cpu-audio-controller : phandle of the CPU's audio controller
or perhaps:
simple-audio,cpu-port : phandle of the CPU's audio port
or since I assume this binding assumes I2S rather than say AC'97 or SlimBus, perhaps:
simple-audio,i2c-controller : phandle of the CPU's I2S controller
The binding is pretty agnostic as to the interface given that the bus-specifics are in optional properties.
+- simple,asoc,sysclk : system clock rate
"clock-frequency" rather than "sysclk" would be more consistent with other bindings.
I think specifying the particular clock being referenced is useful here - we may also end up wanting to specify the BCLK or sample rate due to some hardware limitation on some system both of which are clocks too.