On Wed, Mar 02, 2016 at 01:11:01PM +0900, Mark Brown wrote:
- [VOICE_DAI] = {
.name = "Voice",
.stream_name = "Voice",
.cpu_dai_name = "snd-soc-dummy-dai",
.codec_name = "wm8994-codec",
.codec_dai_name = "wm8994-aif2",
.platform_name = "snd-soc-dummy",
Why are you mapping in dummy DAIs? If these devices aren't connected then they're not connected and you shouldn't represent them. If they are connected to something then describe those connections, possibly in followup patches if you have other devices you need to support upstream first.
From his previous reply to me (he forgot to use reply-all), he
told me that he only tested the aif1 path in the release while leaving aif2 and aif3 for future use.
In his schematics of the reference board, I found all three aifs are "connected" but AIF2 and AIF3 are optional through jumpers. So I think it might be better for him to make the driver flexible by including all three aifs while creating dai-links depending on the presence of corresponding cpu-dais.
Thanks Nicolin