7 Aug
2009
7 Aug
'09
12:19 p.m.
On Fri, Aug 07, 2009 at 12:02:00AM +0100, Ben Dooks wrote:
- /* Speaker is connected to LINEOUT{LN,LP,RN,RP} */
+};
Missing routes? The comment should at least be a bit clearer about why they're not there.
- snd_soc_dapm_enable_pin(codec, "Headphone Jack");
- snd_soc_dapm_enable_pin(codec, "Line In");
- snd_soc_dapm_enable_pin(codec, "Line Out");
- snd_soc_dapm_enable_pin(codec, "Mic Jack");
This is not required since pins are enabled by default but it's OK to leave this here for documentation.
+static struct aic3x_setup_data codec_setup = {
- .i2c_bus = 0,
- .i2c_already = 1,
+};
This patch should have been submitted after your previous patch to the CODEC driver since it depends on it.
+static int __devinit simtec_audio_hermes_probe(struct platform_device *pd) +{
- dev_info(&pd->dev, "probing....\n");
- return simtec_audio_core_probe(pd, &simtec_snd_devdata_aic33);
+}
Please remove the printk() here.