Re: [PATCH 11/11] ASoC: topology: Use unload() op directly

On 1/27/23 17:11, Amadeusz Sławiński wrote:

struct snd_soc_dobj only needs pointer to the unload function, instead however, there is pointer to all topology operations. Change code to use the function pointer instead of pointer to structure containing all operations.

I still don't see what we gain with this change.

what we had was:

sbe->dobj.ops = tplg->ops;

if (dobj->ops && dobj->ops->control_unload) dobj->ops->control_unload(comp, dobj);

and now we have this:

if (tplg->ops) sbe->dobj.unload = tplg->ops->control_unload; if (dobj->unload) dobj->unload(comp, dobj);

The improvement is far from obvious to me.

Not going to lay on the tracks for this though.