On Thu, 15 May 2025 17:47:25 +0200, Daniel Dadap wrote:
Some systems expose HD-Audio controllers via objects in the ACPI tables which encapsulate the controller's interrupt and the base address for the HDA registers in an ACPI _CRS object, for example, as listed in this ACPI table dump excerpt:
Device (HDA0) { Name (_HID, "NVDA2014") // _HID: Hardware ID ... Name (_CRS, ResourceTemplate () // _CRS: Current Resource Settings { Memory32Fixed (ReadWrite, 0x36078000, // Address Base 0x00008000, // Address Length ) Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, ) { 0x0000021E, } }) }Add support for HDA controllers discovered through ACPI, including support for some platforms which expose such HDA controllers on NVIDIA SoCs. This is done with a new driver which uses existing infrastructure for extracting resource information from _CRS objects and plumbs the parsed resource information through to the existing HDA infrastructure to enable HD-Audio functionality on such devices.
Although this driver is in the sound/pci/hda/ directory, it targets devices which are not actually enumerated on the PCI bus. This is because it depends upon the Intel "Azalia" infrastructure which has traditionally been used for PCI-based devices.
Signed-off-by: Daniel Dadap ddadap@nvidia.com
Thanks. Now I checked with checkpatch, and it complained a few things:
WARNING: Block comments use a trailing */ on a separate line #168: FILE: sound/pci/hda/hda_acpi.c:79: + * devm_platform_get_and_ioremap_resource() */
ERROR: code indent should use tabs where possible #182: FILE: sound/pci/hda/hda_acpi.c:93: +^I IRQF_SHARED, KBUILD_MODNAME, azx);$
ERROR: code indent should use tabs where possible #308: FILE: sound/pci/hda/hda_acpi.c:219: +^I THIS_MODULE, 0, &hda->card);$
WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure th) #405: FILE: sound/pci/hda/hda_acpi.c:316: +MODULE_LICENSE("GPL v2");
Care to address those and resubmit?
thanks,
Takashi