13 Aug
2024
13 Aug
'24
1:35 p.m.
On Tue, Aug 13, 2024 at 12:51:49PM +0800, Zhang Yi wrote:
To adapt to chrome, we have adjusted the buttons to match the system.
case 0x4b: /* button volume up */
cur_button = SND_JACK_BTN_1;
cur_button = SND_JACK_BTN_2;
cur_button = SND_JACK_BTN_2;
cur_button = SND_JACK_BTN_3;
This is really problematic, we're changing the keys reported here in a way that's not ABI compatible. If this was a new driver then fine but this is quite old, it's in LTS releases, so we might be disrupting people's existing systems. I'm not sure we have a good solution for this at this point, we're not even swapping the buttons here but rather using a different set of buttons. Probably ChromeOS needs to work around this somehow, or we need to add some mechanism which allows userspace to configure the driver mapping at runtime.