Hello Mark,
On Fri, 27 Dec 2019 22:52:04 +0000, Mark Brown broonie@kernel.org wrote:
On Fri, Dec 27, 2019 at 04:20:56PM +0100, Peter Seiderer wrote:
Fixes:
[ 5.169310] Division by zero in kernel. [ 5.200998] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 5.3.18-20191021-1+ #14 [ 5.203049] cdc_acm 2-1.6:1.0: ttyACM0: USB ACM device [ 5.208198] Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree) [ 5.220084] Backtrace: [ 5.222628] [<8010f60c>] (dump_backtrace) from [<8010f9a8>] (show_stack+0x20/0x24)
Please think hard before including complete backtraces in upstream reports, they are very large and contain almost no useful information relative to their size so often obscure the relevant content in your message. If part of the backtrace is usefully illustrative then it's usually better to pull out the relevant sections.
Thanks for review..., but a little disagree here, do not know much which is more informative than a complete back trace for a division by zero (and which is the complete information/starting point for investigating the reason therefore) and it would be a pity to loose this valuable information?
Maybe I should have added more information about why and how the failing regmap_read() call leads to a division by zero?
Any hint for a better commit message is welcome ;-)
Regards, Peter