On Tue, Jun 18, 2019 at 11:12:58AM -0700, Curtis Malainey wrote:
On Tue, Jun 18, 2019 at 11:01 AM Fletcher Woodruff
On Sun, Jun 16, 2019 at 10:56 AM Cezary Rojewski
On 2019-06-14 21:48, Fletcher Woodruff wrote:
ret = regmap_read(rt5677->regmap, RT5677_IRQ_CTRL1, ®_irq);if (ret) {pr_err("rt5677: failed reading IRQ status: %d\n", ret);
The entire rt5677 makes use of dev_XXX with the exception of.. this very function. Consider reusing "component" field which is already part of struct rt5677_priv and removing pr_XXX.
I was using dev_XXX, but I believe Curtis found that 'component' was sometimes uninitialized when this function was called, so I switched back to pr_XXX. I may be misremembering though, so I'll let Curtis comment as well.
The issue here is that the IRQ is setup in the i2c probe and the component is setup in the codec probe. In theory if the hardware is in
The component is not needed for a struct device, you must have a struct device if you have a regmap or have probed at all.