Re: [alsa-devel] [PATCH] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug unconditionally

13 Sep 2012


      ...
-----Original Message-----
From: Wu, Fengguang
Sent: Thursday, September 13, 2012 11:14 AM
To: Wang, Xingchao
Cc: intel-gfx@lists.freedesktop.org; alsa-devel@alsa-project.org;
daniel.vetter@ffwll.ch; tiwai@suse.de; Zhao, Yakui; Fu, Michael
Subject: Re: [PATCH] drm/i915: HDMI - Clear Audio Enable bit for Hot Plug
unconditionally
...
u32 enable_bits = SDVO_ENABLE;

if (intel_hdmi->has_audio)
enable_bits |= SDVO_AUDIO_ENABLE;


enable_bits |= SDVO_AUDIO_ENABLE;

The two lines can be combined:
u32 enable_bits = SDVO_ENABLE | SDVO_AUDIO_ENABLE;
Looks better, I send out V2 patch for Daniel.
-- Xingchao