On Tue, May 15, 2012 at 01:53:50PM +0200, Philippe Rétornaz wrote:
Signed-off-by: Philippe Rétornaz philippe.retornaz@epfl.ch
This looks broadly good from a framework point of view but it's a bit depressing that there are so many magic numbers even for register names - it makes the code rather impenetrable and I wouldn't like to be maintaining it. I'll go ahead and apply it if Samuel is OK with patch 1 going via ASoC (there's a build dependency).
A few smallish things, please fix incrementally (or roll into a new version if you're resubmitting for some reason):
- snd_soc_add_codec_controls(codec, mc13783_control_list,
ARRAY_SIZE(mc13783_control_list));- snd_soc_dapm_new_controls(dapm, mc13783_dapm_widgets,
ARRAY_SIZE(mc13783_dapm_widgets));- snd_soc_dapm_add_routes(dapm, mc13783_routes,
ARRAY_SIZE(mc13783_routes));
These should all be assigned in the CODEC driver structure.
+static __init int mc13783_init(void) +{
- return platform_driver_register(&mc13783_codec_driver);
+}
+static __exit void mc13783_exit(void) +{
- platform_driver_unregister(&mc13783_codec_driver);
+}
+module_init(mc13783_init); +module_exit(mc13783_exit);
module_platform_driver().