[alsa-devel] [PATCH 1/2] ALSA: ctxfi: Deletion of an unnecessary check before the function call "kfree"

From: Markus Elfring elfring@users.sourceforge.net Date: Tue, 2 Dec 2014 20:00:33 +0100

The kfree() function performs also input parameter validation. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring elfring@users.sourceforge.net --- sound/pci/ctxfi/ctdaio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/pci/ctxfi/ctdaio.c b/sound/pci/ctxfi/ctdaio.c index c1c3f88..1712332 100644 --- a/sound/pci/ctxfi/ctdaio.c +++ b/sound/pci/ctxfi/ctdaio.c @@ -577,7 +577,7 @@ static int get_daio_rsc(struct daio_mgr *mgr, error: if (dao) kfree(dao); - else if (dai) + else kfree(dai);

spin_lock_irqsave(&mgr->mgr_lock, flags);