On Fri, Jun 19, 2015 at 01:24:39PM +0530, Vinod Koul wrote:
On Thu, Jun 18, 2015 at 08:47:40PM +0200, Michele Curti wrote:
# Machine support obj-$(CONFIG_SND_SOC_INTEL_SST) += boards/
Does this last line mean that nothing under the 'boards' folder will compile if the CONFIG_SND_SOC_INTEL_SST option is not enabled?
Tried to replace the line with obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += boards/ and the machine driver builds and installs
I'll try to add a CONFIG_SND_SOC_INTEL_BOARDS selected by both CONFIG_SND_SOC_INTEL_SST and CONFIG_SND_SST_MFLD_PLATFORM :)
Yes you are right, that does cause the issue, we need to get the board to get included, so I am able to reproduce this.
Also I saw you patch, I dont this we need to add a new symbol as boards is the one where one should select the machine and allow other symbold to be auto selected, so better to do this
Yes, much better than mine :p
diff --git a/sound/soc/intel/Makefile b/sound/soc/intel/Makefile index 3853ec2ddbc7..6de5d5cd3280 100644 --- a/sound/soc/intel/Makefile +++ b/sound/soc/intel/Makefile @@ -7,4 +7,4 @@ obj-$(CONFIG_SND_SOC_INTEL_BAYTRAIL) += baytrail/ obj-$(CONFIG_SND_SST_MFLD_PLATFORM) += atom/
# Machine support -obj-$(CONFIG_SND_SOC_INTEL_SST) += boards/ +obj-$(CONFIG_SND_SOC) += boards/
With thhis machine compiles, can you please verify at your end. Also I think
Yes, it works, thank you ;)
we should remove the prompt for SND_SOC_INTEL_SST, this should be selected by respective driver
I will send patches to fix all these
Thanks for reporting
-- ~Vinod