At Thu, 03 Jan 2013 17:04:15 +0100, David Henningsson wrote:
On 12/19/2012 11:38 AM, Takashi Iwai wrote:
At Wed, 19 Dec 2012 11:34:46 +0100, David Henningsson wrote:
On 12/19/2012 11:24 AM, Takashi Iwai wrote:
At Wed, 19 Dec 2012 09:44:47 +0100, David Henningsson wrote:
This reverts commit 697c373e34613609cb5450f98b91fefb6e910588.
The original patch was meant to remove clicking, but in fact caused even more clicking instead.
Thanks to c4pp4 for doing most of the work with this bug.
BugLink: https://bugs.launchpad.net/bugs/886975 Signed-off-by: David Henningsson david.henningsson@canonical.com
@c4pp4: Is this consistent with what you have done to reduce the clicking? Will you recommend upstream Linux to take the patch below?
So, it shouldn't be merged yet right now? Now is the last chance for merging it to 3.8-rc1.
If we don't have time waiting for c4pp4's confirmation without missing the entire 3.8 cycle, then I think we should merge it.
It's no new feature, so it's fine to merge it at any time during 3.8 cycle, even after 3.8-rc1.
But such a fix should be merged with Cc to stable, so a bit more tests would be better.
Do you have a suggestion on how that should be tested? I have no conexant machines here currently.
Well, at best, test 3.8-rc2 with the patch. The content isn't too intrusive so it should suffice for merge. Alternatively, the tester can try older kernel with the same patch.
The point is to confirm that the patch really works.
thanks,
Takashi