On Mon, Mar 7, 2011 at 1:57 PM, Mauro Carvalho Chehab mchehab@redhat.com wrote:
Em 05-03-2011 17:48, Laurent Pinchart escreveu:
Hi Mauro,
Hi Mauro,
On Saturday 05 March 2011 19:22:28 Mauro Carvalho Chehab wrote:
Em 05-03-2011 10:02, Laurent Pinchart escreveu:
Hi Mauro,
Thanks for the review. Let me address all your concerns in a single mail.
- ioctl numbers
I'll send you a patch that reserves a range in Documentation/ioctl/ioctl- number.txt and update include/linux/media.h accordingly.
Ok, thanks.
"media: Pick a free ioctls range" at the top of the http://git.linuxtv.org/pinchartl/media.git?a=shortlog;h=refs/heads/media-2.6... omap3isp branch
Added in the end of my quilt series.
- private ioctls
As already explained by David, the private ioctls are used to control advanced device features that can't be handled by V4L2 controls at the moment (such as setting a gamma correction table). Using those ioctls is not mandatory, and the device will work correctly without them (albeit with a non optimal image quality).
David said he will submit a patch to document the ioctls.
Ok.
Working on that.
Laurent/David, any news on that?
Yes. Sakari has written a first documentation and I'm complementing with statistic's specific usage information.
Regards,
David