Hi Mark, Stephen
simple-audio,codec { simple-audio,dev = &phandle; simple-audio,system-clock-frequency = 122880000; };
I would like to ask you before creating v3 patch. I got some opinions from you. - cpu/codec style (above) - "controller" naming - it is using "name" property (it is must item for matching) Then, what do you think about this style ? fai_ak4642 { compatible = "simple-audio"; simple-audio,card-name = "FSI2A-AK4648"; /* platform */ simple-audio,platform { compatible = "ak4642-hifi"; /* platform name (if needed) */ simple-audio,dev = <&sh_fsi2>; /* format and inversion are here */ simple-audio,format = "left_j"; simple-audio,bitclock-inversion; } /* codec and cpu are same style */ /* codec */ simple-audio,codec { compatible = "ak4642-hifi"; /* codec dai name (this is must item on ASoC) */ simple-audio,dev = <&ak4648>; simple-audio,bitclock-master; /* clock gating is here */ simple-audio,clock-gating = "continuous"; } /* cpu */ simple-audio,cpu { compatible = "fsia-dai"; /* cpu dai name (if needed) */ simple-audio,dev = <&sh_fsi2>; simple-audio,system-clock-frequency = <11289600>; } } Best regards --- Kuninori Morimoto