12 Apr
2013
12 Apr
'13
5:24 p.m.
On 04/12/2013 08:20 AM, Stas Sergeev wrote:
He means that the commit message. Your commit message says what the patch does. It does not say why the patch is needed.
Yes. But what should I add to the commit message, if the only thing I know about this patch, is that I am not getting any sound without it? :) The reason should be obvious for whoever is familiar with that subsystem, but its not me.
Yep, just formalize the "I am not getting any sound with it" statement. :-) Maybe something like: "Because snd-soc-dummy didn't declare any DAI, it was unable to be used for any audio streams."
-gabriel