Re: [alsa-devel] [PATCH 2/2] ASoC: EDB93xx machine sound driver

On Thu, Oct 07, 2010 at 01:50:26PM +1300, Ryan Mallon wrote:

• ret = gpio_request(EP93XX_GPIO_LINE_EGPIO6, "CS4271 SFRM1 Disable");
• if (ret)

• return ret;
  

• ret = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO6, 0);
• if (ret)

• goto free_EGPIO6;
  

• ret = gpio_request(EP93XX_GPIO_LINE_EGPIO1, "CS4271 Reset");
• if (ret)

• goto free_EGPIO6;
  

• ret = gpio_direction_output(EP93XX_GPIO_LINE_EGPIO1, 1);
• if (ret)

• goto free_EGPIO1;
  

It'd seem to make sense for these to be handled by the CODEC driver, using platform data to supply the GPIOs so that their management can be integrated with the CODEC flow?

Otherwise this looks good.