8 Apr
2015
8 Apr
'15
11:50 a.m.
On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote:
+static void max98090_i2c_shutdown(struct i2c_client *i2c) +{
- struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev);
- dev_info(&i2c->dev, "shut down device\n");
Remove this, it's adding noise.
- /* Enable volume smoothing, disable zero cross. This will cause
* a quick 40ms ramp to mute on shutdown.*/- regmap_write(max98090->regmap,
M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK);- regmap_write(max98090->regmap,
M98090_REG_DEVICE_SHUTDOWN, 0x00);- msleep(40);
+}
This is OK but equivalent code should be being added to the driver remove path as the same thing should be happening there.