On Thu, Apr 26, 2018 at 10:08:13AM +0530, Sanyog Kale wrote:
On Thu, Apr 26, 2018 at 09:58:56AM +0530, Vinod Koul wrote:
We should have kept zero bandwidth check here because there is no need to perform sdw_program_params when no stream is running on bus.
Looking at it I think it helps to program the calculated values, we may get a new stream even before we get a chance to suspend. And frankly at bus, we should not make any assumptions about suspend behaviour they may change with platforms and archs :)
Whats the use of computing & programming values when there is no stream running? The computing and programming of values for new stream will be done in new stream setup flow ie. in prepare, nothing needs to be done here.
I agree we should not make any suspend behaviour assumption here.
That is why programming this is required :)
In case of zero bandwidth, we should just change the stream state to DEPREPARE and return.
Yes agreed and have fixed it, perhaps you missed below:
Change the state to DEPREPARE and then return.
good spot will fix