On 2017-12-20 12:54, Jarkko Nikula wrote:
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote:
On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote:
On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote:
On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote:
Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible.
[]
diff --git a/sound/soc/omap/mcbsp.c b/sound/soc/omap/mcbsp.c
[]
@@ -854,7 +854,7 @@ static ssize_t dma_op_mode_store(struct device *dev, return size; }
-static DEVICE_ATTR(dma_op_mode, 0644, dma_op_mode_show, dma_op_mode_store); +static DEVICE_ATTR_RW(dma_op_mode);
While I can ack this part here if it helps generic cleanup effort I don't understart would it improve code readability in general? Mode 644 is clear and don't need any grepping but for DEVICE_ATTR_RW() I had to go through all of these files in order to see what does it mean:
Yeah, 644 is "clear", but _RW() is even more clear. Ideally I want to get rid of all of the "non-standard" users that set random modes of sysfs files, as we get it wrong too many times. Using the "defaults" is much better.
Fair enough. For the sound/soc/omap/ (Acked-by was missing from my previous reply):
Acked-by: Jarkko Nikula jarkko.nikula@bitmer.com
And from me to the same file (sound/soc/omap/mcbsp.c):
Acked-by: Peter Ujfalusi peter.ujfalusi@ti.com
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki