16 Oct
2023
16 Oct
'23
1:58 p.m.
On Mon, Oct 16, 2023 at 04:10:17PM +0800, wangweidong.a@awinic.com wrote:
On Fri, Oct 13, 2023 at 03:10:56 PM +0100, broonie@kernel.org wrote:
+static int aw_dev_dsp_update_container(struct aw_device *aw_dev,
unsigned char *data, unsigned int len, unsigned short base)+{
- int i, ret;
+#ifdef AW88399_DSP_I2C_WRITES
- u32 tmp_len;
This looks like debug code which can hopefully be removed in favour of the regmap implementation?
Thank you very much, but this is not a debugging statement, This is designed to be compatible with different platforms that may not support continuous writing.
If this is needed for platform comaptibility then it needs to be something selected at runtime, ideally regmap would be able to hide whatever's going on but perhaps the register address loading complicates things there.