Re: [alsa-devel] [PATCH 3/3] sound: ASoC: tegra: Select tegra30 i2s and ahub for tegra124 SoC

On 04/18/2017 09:11 AM, Paul Kocialkowski wrote:

This selects the tegra30 i2s and ahub controllers for the tegra124 SoC. These are needed when building without ARCH_TEGRA_3x_SOC set.

diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kconfig index efbe8d4c019e..bcd18d2cf7a7 100644 --- a/sound/soc/tegra/Kconfig +++ b/sound/soc/tegra/Kconfig @@ -46,7 +46,7 @@ config SND_SOC_TEGRA20_SPDIF

config SND_SOC_TEGRA30_AHUB tristate

• depends on SND_SOC_TEGRA && ARCH_TEGRA_3x_SOC

• depends on SND_SOC_TEGRA && (ARCH_TEGRA_3x_SOC || ARCH_TEGRA_124_SOC)

Is this really a compile-time dependency? If so, don't we need to add T210 and T186 entries into that || condition too, since we could be building a kernel with just T210/T186 support and no T124 support?