On Thu, Apr 09, 2015 at 12:25:28PM +0200, Wolfram Sang wrote:
It doesn't really matter that the error codes are different, it matters that they are meaningful. As much as possible you should pass error codes from the lower layers. parport_claim_or_block() and i2c_bit_add_bus() return proper error codes so you should record and transmit them.
Oh, surely yes. I assumed they don't and this series is a first step to fix this. Should have looked myself. Thanks for jumping in here.
I planned this series to be the first step to fix the attach function which does not return it succeeded or failed. And if attach has failed then there is no reason that module_init will report success.
But as Greg pointed out that the first step should be to bring the parallel port in the driver model. I am working on that now, I will post a v2 of this series once that modification is done, and that will need extensive testing.
regards sudip