Re: [PATCH 1/3] ASoC: qcom: q6core: expose ADSP core firmware version

On Sat, Oct 14, 2023 at 07:26:22PM +0200, Otto Pflüger wrote:

• for (i = 0; i < g_core->svc_version->num_services; i++) {
  

• 	struct avcs_svc_info *info;
  

• 	info = &g_core->svc_version->svc_api_info[i];
  

• 	if (info->service_id != APR_SVC_ADSP_CORE)
  

• 		continue;
  

• 	switch (info->version) {
  

• 	case AVCS_CMDRSP_Q6_ID_2_6:
  

• 		core->adsp_version = Q6_ADSP_VERSION_2_6;
  

• 		break;
  

• 	case AVCS_CMDRSP_Q6_ID_2_7:
  

• 		core->adsp_version = Q6_ADSP_VERSION_2_7;
  

• 		break;
  

• 	case AVCS_CMDRSP_Q6_ID_2_8:
  

• 		core->adsp_version = Q6_ADSP_VERSION_2_8;
  

• 		break;
  

• 	}
  

This doesn't handle unknown versions at all.