12 Dec
2014
12 Dec
'14
2:27 p.m.
On Wed, Dec 10, 2014 at 08:15:26PM -0800, Ben Zhang wrote:
The MICBIAS voltage for IN1 can be set to 1.476V/2.970V/1.242V/2.475V
The changelog says "platform config" but this is adding DT binding.
+- realtek,micbias1
- Select 0/1/2/3 to set MICBIAS1 voltage to 1.476V/2.970V/1.242V/2.475V
Why is this being specified as some magic number rather than using the voltage (or at least providing defines for the voltage) - this is going to do little to make the DT legible and...
+enum rt5677_micbias {
- RT5677_MICBIAS_1_476V = 0,
- RT5677_MICBIAS_2_970V = 1,
- RT5677_MICBIAS_1_242V = 2,
- RT5677_MICBIAS_2_475V = 3,
+};
...I see there are defined for platform data.