On Mon, Sep 28, 2015 at 09:49:35PM +0300, Jyri Sarha wrote:
On 09/19/15 21:42, Mark Brown wrote:
What's the use case again? Can we address this by converting the relevant drivers to the clock API (or improving their clock API support)?
Sorry, I forgot to reply this earlier. The reason why we need this is the way McASP driver uses and provides clocks for different purposes. The most pressing need is to be able to select if we want to use some external clock pin as an input for McASP clock divider that produces the i2s bit-clock or if we want to use McASP's internal clock source.
There are several other things this binding would allow us, and others with flexible i2s HW, to do. Some TI codecs would also benefit from a flexible way of describing the used clock configuration, but Peter know that part better.
I tried to make the binding as flexible and generic as possible. But I do not currently see any immediate need for more than one set_sysclk() call per dai. I just did not see any reason to not allow it either.
This explains why you want to do this but what about the clock API portion of the question - it would be good to move the ASoC clocking more into the clock API, this would help integration with wider clock trees.