Re: [alsa-devel] [PATCH v6] ASoC: max98090: remove 24-bit format support if RJ is 0

On Tue, Jun 18, 2019 at 10:24:11AM +0800, Yu-Hsuan Hsu wrote:

• /*

• * When TDM = 0, remove 24-bit format support if it is not in right
  

• * justified mode.
  

• */
  

• if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) != SND_SOC_DAIFMT_RIGHT_J &&

• 	!max98090->tdm_slots)
  

• substream->runtime->hw.formats &= ~SNDRV_PCM_FMTBIT_S24_LE;
  

Why do this and not add a constraint (which doesn't modify any constant data structures)?