On 06/15/2016 11:25 AM, Mark Brown wrote:
On Tue, Jun 14, 2016 at 04:52:15PM +0200, Sylwester Nawrocki wrote:
On 06/13/2016 05:14 PM, Mark Brown wrote:
Removed the regulator handling code? Why?
Because it was effectively a dead code (disabled by a DT flag property) and didn't make any sense on our test board. It was setting regulator's load and voltage on a shared fixed voltage regulator. Even if calls like regulator_set_optimum_mode() were added that wouldn't make any difference, since the corresponding PMIC driver ops were not implemented. I started more or less with something like this [1].
The mode and voltage setting code there are just obviously broken but having the get and enable is useful, even if it doesn't do anything on your board it's nice to have them there already to avoid any transition issues adding them later and help get more complete and accurate DTs in from the get go.
OK, I've added regulator supply related code and properties to the DT binding.