Re: [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280 hardware param fixup callback

1 Feb 2023

      On Wed, Feb 01, 2023 at 07:19:35PM +0530, Mohammad Rafi Shaik wrote:
...
+#define DEFAULT_SAMPLE_RATE_48K	48000
Why are we bothering with a define here given that the define also
encodes the value and it's only used in once place?
...
for_each_card_prelinks(card, i, link) {
   	link->init = sc7280_init;
   	link->ops = &sc7280_ops;

if (link->no_pcm == 1)

	link->be_hw_params_fixup = sc7280_snd_be_hw_params_fixup;

We only set the fixup in the case where there's no PCM but we removed
the constraint in all cases - isn't the constraint needed otherwise?

Re: [PATCH 02/14] ASoC: qcom: SC7280: audioreach: Add sc7280 hardware param fixup callback

Mark Brown