Re: [alsa-devel] [PATCH] Uninitialized id returned by saffirepro_both_clk_src_get.

Hi,

On Oct 27 2014 22 13 Takashi Iwai wrote:

About the patch:

...

...

+/* Value maps between registers and labels for SaffirePro 10/26. */ +static const char saffirepro_clk_maps[][SAFFIREPRO_CLOCK_SOURCE_COUNT] = {

• /* SaffirePro 10 */
• [0] = {

• [SAFFIREPRO_CLOCK_SOURCE_INTERNAL]  =  0,
  

• [SAFFIREPRO_CLOCK_SOURCE_SKIP]      = -1, /* not supported */
  

If you need to handle a negative value, you must specify "signed char". Without "signed" prefix, it might be unsigned, depending on the architecture, in the case of char.

...

...

static int saffirepro_both_clk_src_get(struct snd_bebob *bebob, unsigned int *id) { int err;

• u32 value;

• u32 value; /* clock source read from hw register */
• const char *map;

Ditto.

Yep, exactly. I missed them...

Thanks for your indication and applying to the branch, C.C.ed to stable: http://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?h=for-li...

Regards

Takashi Sakamoto o-takashi@sakamocchi.jp