Re: [alsa-devel] [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver

14 Jul 2011

      ...
-----Original Message-----
From: alsa-devel-bounces@alsa-project.org [mailto:alsa-devel-
bounces@alsa-project.org] On Behalf Of Wolfram Sang
Sent: Wednesday, July 13, 2011 11:58 PM
To: Dong Aisheng-B29396
Cc: alsa-devel@alsa-project.org; s.hauer@pengutronix.de;
broonie@opensource.wolfsonmicro.com; u.kleine-koenig@pengutronix.de;
lrg@ti.com; linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH V2 03/10] ASoc: mxs: add mxs-sgtl5000
machine driver
...
+#include <linux/module.h>
+#include <linux/moduleparam.h>
No parameters here, drop it.
...
+#include <linux/device.h>
+#include <linux/i2c.h>
+#include <linux/fsl_devices.h>
+#include <linux/gpio.h>
The last three, too.
...

/* sgtl5000 does not support 512*rate when in 96000 fs */
rate = params_rate(params);

...so this line can go.
Updated.
Thanks.
Regards
Dong Aisheng