Re: [PATCH] slimbus: qcom-ngd-ctrl: Use platform_get_irq() to get the interrupt

Hi Srinivas,

On Fri, Dec 24, 2021 at 4:13 PM Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com wrote:

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static allocation of IRQ resources in DT core code, this causes an issue when using hierarchical interrupt domains using "interrupts" property in the node as this bypasses the hierarchical setup and messes up the irq chaining.

In preparation for removal of static setup of IRQ resource from DT core code use platform_get_irq().

Signed-off-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com

Hi,

Dropping usage of platform_get_resource() was agreed based on the discussion [0].

[0] https://patchwork.kernel.org/project/linux-renesas-soc/ patch/20211209001056.29774-1-prabhakar.mahadev-lad.rj@bp.renesas.com/

Cheers, Prabhakar

---

drivers/slimbus/qcom-ngd-ctrl.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)

This patch is not in -next yet. When do you plan to merge this patch?

Cheers, Prabhakar

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c index 7040293c2ee8..0f29a08b4c09 100644 --- a/drivers/slimbus/qcom-ngd-ctrl.c +++ b/drivers/slimbus/qcom-ngd-ctrl.c @@ -1526,13 +1526,11 @@ static int qcom_slim_ngd_ctrl_probe(struct platform_device *pdev) if (IS_ERR(ctrl->base)) return PTR_ERR(ctrl->base);

•   res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
  

•   if (!res) {
  

•           dev_err(&pdev->dev, "no slimbus IRQ resource\n");
  

•           return -ENODEV;
  

•   }
  

•   ret = platform_get_irq(pdev, 0);
  

•   if (ret < 0)
  

•           return ret;
  
  

•   ret = devm_request_irq(dev, res->start, qcom_slim_ngd_interrupt,
  

•   ret = devm_request_irq(dev, ret, qcom_slim_ngd_interrupt,
                           IRQF_TRIGGER_HIGH, "slim-ngd", ctrl);
    if (ret) {
            dev_err(&pdev->dev, "request IRQ failed\n");
  

-- 2.17.1