-----Original Message----- From: Vinod Koul vkoul@kernel.org Sent: Thursday, May 21, 2020 12:37 PM To: Liao, Bard bard.liao@intel.com Cc: Bard Liao yung-chuan.liao@linux.intel.com; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org; gregkh@linuxfoundation.org; jank@cadence.com; srinivas.kandagatla@linaro.org; rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com; hui.wang@canonical.com; pierre- louis.bossart@linux.intel.com; Kale, Sanyog R sanyog.r.kale@intel.com; Blauciak, Slawomir slawomir.blauciak@intel.com; Lin, Mengdong mengdong.lin@intel.com Subject: Re: [PATCH 2/2] soundwire: intel: transition to 3 steps initialization
On 21-05-20, 02:23, Liao, Bard wrote:
-----Original Message----- From: Vinod Koul vkoul@kernel.org Sent: Wednesday, May 20, 2020 9:54 PM To: Bard Liao yung-chuan.liao@linux.intel.com Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; tiwai@suse.de; broonie@kernel.org; gregkh@linuxfoundation.org; jank@cadence.com; srinivas.kandagatla@linaro.org; rander.wang@linux.intel.com; ranjani.sridharan@linux.intel.com; hui.wang@canonical.com; pierre- louis.bossart@linux.intel.com; Kale, Sanyog R sanyog.r.kale@intel.com; Blauciak, Slawomir slawomir.blauciak@intel.com; Lin, Mengdong mengdong.lin@intel.com; Liao, Bard bard.liao@intel.com Subject: Re: [PATCH 2/2] soundwire: intel: transition to 3 steps initialization
On 20-05-20, 03:19, Bard Liao wrote:
From: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Rather than a plain-vanilla init/exit, this patch provides 3 steps in the initialization (ACPI scan, probe, startup) which makes it easier to detect platform support for SoundWire, allocate required resources as early as possible, and conversely help make the startup() callback lighter-weight with only hardware register setup.
Okay but can you add details in changelog on what each step would do?
Sure. Will do.
@@ -1134,25 +1142,15 @@ static int intel_probe(struct platform_device
*pdev)
intel_pdi_ch_update(sdw);
- /* Acquire IRQ */
- ret = request_threaded_irq(sdw->link_res->irq,
sdw_cdns_irq, sdw_cdns_thread,IRQF_SHARED, KBUILD_MODNAME, &sdw-cdns);
This is removed here but not added anywhere else, do we have no irq after this patch?
We use a single irq for all Intel Audio DSP events and it will be requested in the SOF driver.
And how will the irq be propagated to sdw/cdns drivers here?
We export the handler and call it on SOF driver.
-- ~Vinod