Re: [alsa-devel] [PATCH v1 2/3] ASoC: codecs: msm8916-analog: support jack detection

On Tue, Jul 25, 2017 at 01:51:25PM -0400, Damien Riegel wrote:

• for (i = 0; i < ARRAY_SIZE(jack_detect_irqs); i++) {

• int irq;
  

• irq = platform_get_irq_byname(pdev, jack_detect_irqs[i].name);
  

• if (irq < 0) {
  

• 	dev_warn(dev, "failed to get irq '%s', jack insertion detection disabled\n",
  

• 		 jack_detect_irqs[i].name);
  

• 	break;
  

• }
  

• ret = devm_request_threaded_irq(dev, irq, NULL,
  

Don't put the loop in when there's only one IRQ, wait till it's needed. This is an unusual pattern and it's not clear that just bombing out of the loop with interrupts half requested is a good idea.