On 8/1/2018 10:20 AM, Takashi Iwai wrote:
On Wed, 01 Aug 2018 05:46:48 +0200, kbuild test robot wrote:
Hi Rohit,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on asoc/for-next] [also build test WARNING on next-20180731] [cannot apply to v4.18-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Rohit-kumar/Add-support-for-audio-o... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
sound/soc/qcom/sdm845.c:193:27: sparse: incorrect type in argument 2 (different base types) @@ expected unsigned int [unsigned] val @@ got restricted snd_unsigned int [unsigned] val @@
sound/soc/qcom/sdm845.c:193:27: expected unsigned int [unsigned] val sound/soc/qcom/sdm845.c:193:27: got restricted snd_pcm_format_t [usertype] <noident>vim +193 sound/soc/qcom/sdm845.c
181 182 static int sdm845_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd, 183 struct snd_pcm_hw_params *params) 184 { 185 struct snd_interval *rate = hw_param_interval(params, 186 SNDRV_PCM_HW_PARAM_RATE); 187 struct snd_interval *channels = hw_param_interval(params, 188 SNDRV_PCM_HW_PARAM_CHANNELS); 189 struct snd_mask *fmt = hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT); 190 191 rate->min = rate->max = DEFAULT_SAMPLE_RATE_48K; 192 channels->min = channels->max = 2;193 snd_mask_set(fmt, SNDRV_PCM_FORMAT_S16_LE);
FYI, we have introduced a new helper, snd_mask_set_format(), just for avoiding this sparse warning. It's already in Mark's for-next tree.
Thanks Takashi for API suggestion. I will update in next spin.
thanks,
Takashi