21 Mar
2019
21 Mar
'19
1:31 p.m.
On Thu, Mar 21, 2019 at 03:41:25PM +0530, Pankaj Bharadiya wrote:
outfree_kcontrol_news: devm_kfree(card->dev, (void *)template.kcontrol_news);
- snd_soc_dapm_free_kcontrol(card, &private_value,
rtd->dai_link->num_params, w_param_text);
- if (w_param_text)
snd_soc_dapm_free_kcontrol(card, &private_value,rtd->dai_link->num_params, w_param_text);
This is very non-obvious - it's not at all clear why we'd need the text to free controls. If there is an issue here it seems like it'd be better to make sure that snd_soc_dapm_free_kcontrol() can cope with that being NULL, that will be clearer and also avoid potential issues with other callers.