On Wed, May 13, 2020 at 3:47 PM Steve Lee steves.lee.maxim@gmail.com wrote:
+++ b/sound/soc/codecs/max98390.c @@ -0,0 +1,1030 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/*
- max98390.c -- MAX98390 ALSA Soc Audio driver
- Copyright (C) 2020 Maxim Integrated Products
- */
My previous comments on Gerrit may confuse you. Please use C++ style comments (i.e. // for all lines) here as the maintainer asked.
Mark, may I ask why we need to do so? Is it also applicable to header files?
+static int max98390_dsm_calib_get(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
/* Do nothing. */return 0;+}
This is an intentional NOP.
+static int max98390_dsm_calib_put(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
struct snd_soc_component *component =snd_soc_kcontrol_component(kcontrol);max98390_dsm_calibrate(component);return 0;+}
Entry point from userspace to start to calibrate.
+++ b/sound/soc/codecs/max98390.h @@ -0,0 +1,663 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/*
- Copyright (c) 2020, Maxim Integrated.
- */
I guess these block would also need to use C++ style comment.