On Sun, 11 Oct 2015, Takashi Sakamoto wrote:
Hi,
On Oct 11 2015 06:24, Julia Lawall wrote:
The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec, snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are initialized. Make them all const.
Done with the help of Coccinelle.
Signed-off-by: Julia Lawall Julia.Lawall@lip6.fr
v2: extend to snd_bebob_clock_spec, snd_bebob_meter_spec, and snd_bebob_spec structures.
sound/firewire/bebob/bebob.c | 2 +- sound/firewire/bebob/bebob.h | 32 ++++++++++++++++---------------- sound/firewire/bebob/bebob_focusrite.c | 26 +++++++++++++------------- sound/firewire/bebob/bebob_maudio.c | 32 ++++++++++++++++---------------- sound/firewire/bebob/bebob_pcm.c | 2 +- sound/firewire/bebob/bebob_proc.c | 6 +++--- sound/firewire/bebob/bebob_stream.c | 6 +++--- sound/firewire/bebob/bebob_terratec.c | 10 +++++----- sound/firewire/bebob/bebob_yamaha.c | 6 +++--- 9 files changed, 61 insertions(+), 61 deletions(-)
Tested-by: Takashi Sakamoto o-takashi@sakamocchi.jp Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Thank you to include my extra request and spend more time for this patch ;)
But I prefer to change the title of this patch to 'ALSA: bebob: constify some structures because they are never modified' or something like it because this patch is not only for 'struct snd_bebob_rate_spec'.
Sorry not to have paid attention to that. I will send it again.
julia