Re: [alsa-devel] [PATCH] ASoC: Intel: Add support for PM ops in bxt-da7219_max98357a

On Fri, Jun 17, 2016 at 12:14:07PM +0100, Mark Brown wrote:

On Fri, Jun 17, 2016 at 10:03:30AM +0530, Vinod Koul wrote:

...

+static void broxton_complete(struct device *dev) +{

• snd_soc_resume(dev);

+}

+#else +#define broxton_complete NULL +#endif

Just use snd_soc_resume() directly.

Nope, that leads to warnings.

.complete is the only callback that expects void return whereas snd_soc_resume like other returns int.

struct dev_pm_ops { int (*prepare)(struct device *dev); void (*complete)(struct device *dev); int (*suspend)(struct device *dev); int (*resume)(struct device *dev); ... }

Thanks