, Brent Lu wrote:
This DMI product family string of this board is "Google_Hatch" so the DMI quirk will take place. However, this board is using rt1015 speaker amp instead of max98357a specified in the quirk. Therefore, we need an new DMI quirk for this board.
Do you actually need a DMI quirk for this platform?
the .driver_data below uses the exact same settings as what you would use with the generic solution based on ACPI IDs, see below.
Wondering if patch1 would be enough?
Dooly has DMI family string " Google_Hatch" so the DMI quirk will overwrite the driver_data. I asked google but they prefer not removing this string so it seems to me that one extra DMI quirk is needed.
{ .callback = sof_rt5682_quirk_cb, .matches = { DMI_MATCH(DMI_PRODUCT_FAMILY, "Google_Hatch"), }, .driver_data = (void *)(SOF_RT5682_MCLK_EN | SOF_RT5682_MCLK_24MHZ | SOF_RT5682_SSP_CODEC(0) | SOF_SPEAKER_AMP_PRESENT | SOF_RT5682_SSP_AMP(1)), },
The other way is using acpi_dev_present() in probe to update the quirk with correct codec setting. Which one do you think is better?
Regards, Brent