On Thu, 13 Jun 2024 at 15:13, Srinivas Kandagatla srinivas.kandagatla@linaro.org wrote:
There is an issue around with error handling and graph management with the exising code, none of the error paths close the graph, which result in leaving the loaded graph in dsp, however the driver thinks otherwise.
This can have a nasty side effect specially when we try to load the same graph to dsp, dsp returns error which leaves the board with no sound and requires restart.
Fix this by properly closing the graph when we hit errors between open and close.
Fixes: 30ad723b93ad ("ASoC: qdsp6: audioreach: add q6apm lpass dai support") Signed-off-by: Srinivas Kandagatla srinivas.kandagatla@linaro.org
Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org Tested-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org # X13s
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 32 ++++++++++++++++++++------------ 1 file changed, 20 insertions(+), 12 deletions(-)
[...]
base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
Note: this didn't go to linux-arm-msm, probably because of the use of an outdated tree for submission. This commit is v6.10-rc1, it probably should have been Mark's tree instead or linux-next.
change-id: 20240613-q6apm-fixes-6a9c84852713
Best regards,
Srinivas Kandagatla srinivas.kandagatla@linaro.org