At Wed, 5 Mar 2014 14:05:09 +0300, Dan Carpenter wrote:
Hello Takashi Iwai,
The patch 6f002b02166c: "ALSA: emu10k1: Use standard printk helpers" from Feb 25, 2014, leads to the following static checker warning:
sound/pci/emu10k1/io.c:75 snd_emu10k1_ptr_write() error: we previously assumed 'emu' could be null (see line 74)
sound/pci/emu10k1/io.c 68 void snd_emu10k1_ptr_write(struct snd_emu10k1 *emu, unsigned int reg, unsigned int chn, unsigned int data) 69 { 70 unsigned int regptr; 71 unsigned long flags; 72 unsigned int mask; 73 74 if (!emu) { ^^^^ 75 dev_err(emu->card->dev, "ptr_write: emu is null!\n"); ^^^^^^^^^^^^^^ Dereference.
76 dump_stack(); 77 return;
Damn, this should be simply converted to WARN_ON(). I'll fix it.
thanks,
Takashi