1 Feb
2023
1 Feb
'23
1:23 p.m.
On Tue, 31 Jan 2023 11:02:13 +0100, Dan Carpenter wrote:
This loop accidentally reuses the "i" iterator for both the inside and the outside loop. The value of MAX_STREAM_BUFFER is 5. I believe that chip->rmh.stat_len is in the 2-12 range. If the value of .stat_len is 4 or more then it will loop exactly one time, but if it's less then it is a forever loop.
It looks like it was supposed to combined into one loop where conditions are checked.
Fixes: 8e6320064c33 ("ALSA: lx_core: Remove useless #if 0 .. #endif") Signed-off-by: Dan Carpenter error27@gmail.com
v2: In the first version I just deleted the outside loop but that was not the correct fix. Combine the conditions instead.
Thanks, applied.
Takashi