On Sat, Nov 21, 2009 at 08:12:34PM -0600, Timur Tabi wrote:
On Thu, Nov 19, 2009 at 9:48 AM, Sascha Hauer s.hauer@pengutronix.de wrote:
Signed-off-by: Sascha Hauer s.hauer@pengutronix.de
arch/arm/plat-mxc/Makefile | 1 + arch/arm/plat-mxc/include/mach/ssi.h | 17 + arch/arm/plat-mxc/ssi-fiq.S | 134 ++++ sound/soc/imx/devdma.c | 80 ++ sound/soc/imx/devdma.h | 3 + sound/soc/imx/imx-ssi.c | 1349 ++++++++++++++++++++++++++++++++++ sound/soc/imx/imx-ssi.h | 24 +
Why did you write a new SSI driver when there already is one in sound/soc/fsl?
Mainly because I wasn't aware of the fact that the fsl driver is the same :(
I'm currently looking if and how the code can be merged. I don't know if it's worth it though since the common code doesn't seem to be very big.
There will have to be some changes in the fsl-ssi driver. For example I need the irq handler for my fiq handler which means that the fsl-ssi driver is not allowed to request the irq for it's statistic. The other thing is the hardware accesses as we do not have in_be*, out_be* and setbits/clrbits. Of course all these things are doable and shouldn't be a showstopper.
Sascha