On Tue, Apr 11, 2017 at 11:02:57AM -0500, Rob Herring wrote:
On Tue, Apr 11, 2017 at 9:32 AM, Mark Brown broonie@kernel.org wrote:
The graph card is blocked on your review...
Maybe if there were more reviewers it would move faster. I don't know ASoC that well.
The times I've looked at it recently it's been stuck in DT style issues rather than anything substantially ASoC related, as far as I can tell the binding is essentially empty from an ASoC point of view and inherited from the of_graph binding. There's bits in that are a bit random like specifically listing the CPU DAIs and only them but that just looks like one of these random DT things that's predetermined. I really can't see anything at all in there to review from an ASoC point of view, I've applied the changes that don't seem blocked on the binding. If there's something you're looking for then please say...
We never seem to make any progress on the generic changes in drivers/of at the start of the series either...
I'm also not clear how without something like this we'd be able to identify a specific DAI within a device if we don't have a way of identifying them.
Isn't that what the graph does? "dais" points to a list of ports which are the specific DAIs whether there are multiple ones in a single device or multiple devices with a single DAI each.
But the ports can still have indexes AFAICT (the examples show port@0, port@1 and so on) so we still need to define what those indexes mean which is what this is doing?