Re: [alsa-devel] [PATCH 8/8] ASoC: AMD: Add machine driver for cz rt5650

+static const struct acpi_device_id cz_audio_acpi_match[] = {

• { "I2SC1002", 0 },

This one goes on my list of _HID that don't follow ACPI/PCI vendorID/PartID conventions. AMD shoud use the "AMDI" ACPI ID or the 0x1002 PCI ID for the 4 first characters, if everyone does what they feel like one day we'll have a conflict between devices and probe the wrong driver...

• {},

+};

+static struct platform_driver cz_pcm_driver = {

• .driver = {

• .name = "cz-rt5645",
  

• .acpi_match_table = ACPI_PTR(cz_audio_acpi_match),
  

• .pm = &snd_soc_pm_ops,
  

• },
• .probe = cz_probe,
• .remove = cz_remove,

+};

+module_platform_driver(cz_pcm_driver);

+MODULE_AUTHOR("akshu.agrawal@amd.com"); +MODULE_DESCRIPTION("cz-rt5645 audio support"); +MODULE_LICENSE("GPL v2");