Re: [alsa-devel] [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown

On Thu, May 28, 2015 at 02:45:14PM +0100, Richard Fitzgerald wrote:

+#define ADSP2_SCRATCH0 0x40 +#define ADSP2_SCRATCH1 0x41 +#define ADSP2_SCRATCH2 0x42 +#define ADSP2_SCRATCH3 0x43

May as well dump the other scratches while you're at it?

• unsigned int scratch1 = 0xFFFFFFFF;

Why is this being initialized?

• adsp_dbg(dsp, "Shutdown complete\n");
  

• adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);
  

That seems a bit loud for a diagnostic message, why raise the severity?