At Thu, 12 Mar 2015 20:36:19 -0400, Adam Goode wrote:
Hi,
I found the /* TODO: read port flags from descriptors */ in sound/usb/midi.c and was thinking about what to do to implement this.
The first thing to do would be to ensure that all the flags from the element descriptors in the USB MIDI standard are available for returning from snd_seq_port_info_get_type.
USB MIDI (see page 23): http://www.usb.org/developers/docs/devclass_docs/midi10.pdf
I propose adding these flags to ALSA:
#define SNDRV_SEQ_PORT_TYPE_MIDI_CLOCK (1<<7) /* MIDI CLOCK compatible device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_TIME_CODE (1<<8) /* MTC compatible device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_MACHINE_CONTROL (1<<9) /* MMC compatible device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_EFX (1<<21) /* Audio effects processor device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_PATCH_BAY (1<<22) /* MIDI patcher or router device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_DLS1 (1<<23) /* DownLoadable Sounds Standard Level 1 compatible device */ #define SNDRV_SEQ_PORT_TYPE_MIDI_DLS2 (1<<24) /* DownLoadable Sounds Standard Level 2 compatible device */
Thoughts? I can send a couple patches for the kernel and alsa-lib. I don't think this is a breaking change.
I'm fine with this extension (as long as it's tested :)
Takashi