Re: [alsa-devel] [PATCH v5 01/10] ASoC: phycore-ac97: Add DT support

Hi Markus,

On Wed, Apr 24, 2013 at 04:36:30PM +0200, Markus Pargmann wrote:

Add devicetree support for this audio soc fabric driver.

@@ -32,8 +35,12 @@ static struct snd_soc_dai_link imx_phycore_dai_ac97[] = { .stream_name = "HiFi", .codec_dai_name = "wm9712-hifi", .codec_name = "wm9712-codec", +#ifdef CONFIG_MACH_IMX27_DT

• .platform_name	= "imx-fiq-pcm-audio",
  

+#else .cpu_dai_name = "imx-ssi.0", .platform_name = "imx-fiq-pcm-audio.0", +#endif

This doesn't work properly. Compiling the kernel with IMX27_DT enabled does not necessarily mean that it also started with dt support.

Personally I am fine with removing platform based support for this driver if it's too much effort to fix it properly, but we shouldn't start working with ifdefs here.

Sascha