On Mon, Jan 08, 2018 at 02:23:19PM -0600, Pierre-Louis Bossart wrote:
- /* fixup codec name based on HID */
- i2c_name = snd_soc_acpi_find_name_from_hid(mach->id);
- if (i2c_name) {
snprintf(codec_name, sizeof(codec_name),"%s%s", "i2c-", i2c_name);byt_cht_es8316_dais[dai_index].codec_name = codec_name;- }
this looks good, but I though we had few other places where this was done, esp the BSW based chromebooks, if so would it make send to have a macro in soc-acpi which updates the dai name based on the result from snd_soc_acpi_find_name_from_hid()
Well snd_soc_acpi_find_name_from_hid() will be replaced by an ACPI generic util (see proposal from Andy last week).
The idea was to add this first patch, and then do a replacement across all machine drivers when Andy's patch is available.
Andy also had another idea to add a helper which would take care of the for loop (which would indeed simplify the code further).
If that's alright with everyone, I'd like to add this patch first as is so that folks with the es8316 hardware get working audio, then do the two cleanups later.
Yeah sounds fair to me :)